Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace opengl-cb to render-gl #38

Merged
merged 4 commits into from
Jan 1, 2019
Merged

Replace opengl-cb to render-gl #38

merged 4 commits into from
Jan 1, 2019

Conversation

mchome
Copy link
Contributor

@mchome mchome commented Oct 4, 2018

  1. Replace opengl-cb to render-gl
  2. Add get_property_async
  3. Enable hwdec in example

I put hwdec to auto with no performance upgrade, but lower the cpu usage. The 1080p 60fps big buck bunny still drop frame on my old laptop.
Very cool project, thank you Kagami!

@Kagami Kagami mentioned this pull request Dec 30, 2018
@Kagami
Copy link
Owner

Kagami commented Dec 30, 2018

Hi, sorry for the delay.

This is great, thank you! Seems like mpv's version on travis is too old, I will update it to make sure everything builds and merge your PR.

Not sure why hwdec=auto lowers the CPU usage but still drops frames, but probably won't harm.

@Kagami Kagami closed this Jan 1, 2019
@Kagami Kagami reopened this Jan 1, 2019
@Kagami Kagami self-requested a review January 1, 2019 16:23
@Kagami Kagami merged commit e5adfc2 into Kagami:master Jan 1, 2019
@Kagami
Copy link
Owner

Kagami commented Jan 1, 2019

Merged, thanks!

I had to force-push your fork's master to fix travis build, hope you don't mind.

@mchome
Copy link
Contributor Author

mchome commented Jan 1, 2019

Cool! And this pr may also help #26 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants